Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refetch function info when the url changes #1566

Merged
merged 2 commits into from
Feb 6, 2019

Conversation

karthikvt26
Copy link
Contributor

Fix #1561

Description

Add to component lifecycle method to fetch info again when functionName or schema changes.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

Review app for commit 78755b2 deployed to Heroku: https://hge-ci-pull-1566.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1566-78755b2

Copy link

@rikinsk-zz rikinsk-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works

@hasura-bot
Copy link
Contributor

Review app for commit 2330046 deployed to Heroku: https://hge-ci-pull-1566.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1566-2330046

@rikinsk-zz rikinsk-zz merged commit ad72984 into hasura:master Feb 6, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1566.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Jun 14, 2021
hasura-bot pushed a commit that referenced this pull request Jan 27, 2025
…ets (#1566)

<!-- The PR description should answer 2 important questions: -->

### What
Enabled type checking for preset values provided to fields or arguments
of object types in type, command, or model permissions. This check is
controlled by a compatibility flag, with the date set to the next
release. A warning will be issued for projects with older compatibility
dates. Type check also extended to fields within an object having object
types (nested fields).

### How

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->
Type-checking functions now report issues for object-type value
type-check failures. These are raised as warnings for existing projects
and as strict errors for new projects or those with the latest
compatibility dates.

V3_GIT_ORIGIN_REV_ID: 840c4f2e5ef2bd9c5c307528c3f797fe7ba2070b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in console, from one function page, choosing different function doesnt do anything
5 participants