Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mssql: support event triggers #7228

Closed
0x777 opened this issue Jul 13, 2021 · 15 comments
Closed

mssql: support event triggers #7228

0x777 opened this issue Jul 13, 2021 · 15 comments
Assignees

Comments

@0x777
Copy link
Member

0x777 commented Jul 13, 2021

Similar to what we have for Postgres

@0x777
Copy link
Member Author

0x777 commented Jul 13, 2021

Notes from @nicuveo :


(Documentation for event triggers: https://hasura.io/docs/latest/graphql/core/event-triggers/index.html.)

This is likely to be a long task. First, the code for event triggers need to be generalized (it is Vanilla Postgres only for now);

  • API types are declared in Hasura/RQL/Types/EventTrigger
  • the API itself is in Hasura/RQL/DDL/EventTrigger
  • the invocation code is in Hasura/Eventing

There already are a few functions related to them in BackendMetadata, but I don't know to which extent we've moved the process to the class.

@sassela
Copy link
Contributor

sassela commented Jul 30, 2021

Related issues:
OSS issue
user request

@m4ttheweric
Copy link
Contributor

+1 for this! we love to see sql server support.

@MiteshDhiranAllscripts
Copy link

  • 1 for this!

@jmarbutt
Copy link
Contributor

Also can't wait to see this.

@chrisknu
Copy link

+1 for this!

@ecthiender
Copy link
Member

ecthiender commented Apr 21, 2022

This is now implemented and merged to main via abb57e5. It will be available in the upcoming release. Note that console work is still pending.

cc @tirumaraiselvan @Naveenaidu

@chrisknu
Copy link

Most excellent, thanks!

@jmarbutt
Copy link
Contributor

@ecthiender so can we start using it without the console work in the next release?

@tirumaraiselvan
Copy link
Contributor

@jmarbutt Yeah, it will work without console. Pls do try it out in the next major beta (2.7) !

@jmarbutt
Copy link
Contributor

When will the next major release be available in beta?

@Deluxo
Copy link

Deluxo commented Jun 9, 2022

In release notes of 2.7 I see that MSSQL Event Trigger support is mentioned, but I cannot select MSSQL while creating an Event Trigger (my primary database is PG, MSSQL is a +1).

Is this by design or a bug?

@tirumaraiselvan
Copy link
Contributor

tirumaraiselvan commented Jun 9, 2022 via email

@Deluxo
Copy link

Deluxo commented Jun 9, 2022

Does this mean it's still possible to use it in mssql? Like via API or other ways? @tirumaraiselvan

@tirumaraiselvan
Copy link
Contributor

@Deluxo Yes, you can use the APIs: https://hasura.io/docs/latest/graphql/core/api-reference/metadata-api/event-triggers/#metadata-mssql-create-event-trigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants