Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with ECR #68

Open
tirumaraiselvan opened this issue May 24, 2018 · 7 comments
Open

Integrate with ECR #68

tirumaraiselvan opened this issue May 24, 2018 · 7 comments

Comments

@tirumaraiselvan
Copy link
Collaborator

ECR currently does not automatically create repositories on push unlike docker hub. How (where) should we handle this logic ?

@tirumaraiselvan
Copy link
Collaborator Author

tirumaraiselvan commented May 24, 2018

One way is to ask (infer) the repo in remote CR and create tags instead of creating repositories i.e.

tirumarai/test:247ff5 (dockerhub) becomes

tirumarai:test-247ff5 (ecr)

@shahidhk
Copy link
Member

How easy is it to create the registry? Provided the cluster has required IAM to do so?

@coco98
Copy link
Contributor

coco98 commented May 25, 2018 via email

@tirumaraiselvan
Copy link
Collaborator Author

It is either an HTTP call or aws cli. Either way it breaks the current pattern and proves an exception (till now). If we come up with some other registry which also has the same problem then we need to think about solving the problem more generally. I guess for the time being we can make it a manual step.

@nizar-m
Copy link

nizar-m commented May 25, 2018

Also the authentication to the AWS container registry lasts only for 12 hours. You have to keep renewing the docker credentials. Something like this cronjob will have to be run to keep the imagePullSecret renewed.

@tirumaraiselvan
Copy link
Collaborator Author

@nizar-m Yes, but that is clearly out of the scope of gitkube.

@nizar-m
Copy link

nizar-m commented May 25, 2018

Docker push will fail if you use the command 'aws ecr get-login' to create the dockerPullSecrets and you end up doing it after 12 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants