-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Update Plex Media Server to 1.41.4.9463 #242
Conversation
WalkthroughThe Dockerfile for Plex has been updated. The image now downloads Plex Media Server version Changes
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
plex/Dockerfile (1)
24-26
: Consider Parameterizing the Plex Version
The version string is hardcoded and appears twice in the URL, which may increase maintenance overhead for future updates. Consider introducing a build argument (e.g.,ARG PLEX_VERSION
) to hold the version number and reference it within the URL. This will simplify future updates and reduce duplication.Example diff for suggestion:
+ARG PLEX_VERSION="1.41.4.9463-630c9f557" … - && curl -J -L -o /tmp/plexmediaserver.deb \ - "https://downloads.plex.tv/plex-media-server-new/1.41.4.9463-630c9f557/debian/plexmediaserver_1.41.4.9463-630c9f557_${ARCH}.deb" \ + && curl -J -L -o /tmp/plexmediaserver.deb \ + "https://downloads.plex.tv/plex-media-server-new/${PLEX_VERSION}/debian/plexmediaserver_${PLEX_VERSION}_${ARCH}.deb" \
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
plex/Dockerfile
(1 hunks)
🔇 Additional comments (1)
plex/Dockerfile (1)
24-26
: Plex Media Server Version Updated Properly
The download URL has been updated to fetch Plex Media Server version1.41.4.9463-630c9f557
. Please ensure this new version is valid and has been fully tested within your deployment workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @TheRisenPhoenix 👍
../Frenck
Proposed Changes
⬆️ Update Plex Media Server to 1.41.4.9463
Changes since https://forums.plex.tv/t/plex-media-server/30447/658
Summary by CodeRabbit