Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Drop support for ARMv7 #2016

Merged
merged 1 commit into from
Jan 4, 2025
Merged

🚨 Drop support for ARMv7 #2016

merged 1 commit into from
Jan 4, 2025

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 4, 2025

Proposed Changes

SSIA, this PR drops support for ARMv7 (from several add-ons). I do not see an way out at this point.

Refs:

Summary by CodeRabbit

  • Architecture Support

    • Removed support for armv7 architecture
    • Now supports only aarch64 and amd64 architectures
  • Documentation

    • Updated README.md to reflect architecture support changes

@frenck frenck added major This PR causes a major version bump in the version number. breaking-change A breaking change for existing users. labels Jan 4, 2025
Copy link

coderabbitai bot commented Jan 4, 2025

Walkthrough

The pull request involves removing support for the armv7 architecture from the Home Assistant Community Add-on: Node-RED. This change is consistently applied across multiple configuration files, including the README.md, build.yaml, and config.yaml. The modifications reflect a decision to discontinue support for the armv7 architecture, leaving only aarch64 and amd64 as supported platforms.

Changes

File Change Summary
README.md Updated armv7 architecture badge from green (supported) to red (unsupported)
node-red/build.yaml Removed armv7 entry from build_from section
node-red/config.yaml Removed armv7 from the list of supported architectures

Poem

🐰 Farewell, armv7, you've served us well,
But architectures change, as our story will tell.
Aarch64 and amd64 now take the stage,
A new chapter begins on our coding page!
Hop along, progress, with technological grace! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99a1bb2 and 053165a.

📒 Files selected for processing (3)
  • README.md (1 hunks)
  • node-red/build.yaml (0 hunks)
  • node-red/config.yaml (0 hunks)
💤 Files with no reviewable changes (2)
  • node-red/config.yaml
  • node-red/build.yaml
🔇 Additional comments (1)
README.md (1)

106-106: LGTM! Badge correctly updated to reflect ARMv7 support removal.

The badge update from green to red accurately reflects the architectural changes described in the PR objectives.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frenck frenck merged commit 74a8029 into main Jan 4, 2025
21 checks passed
@frenck frenck deleted the frenck-2025-0026 branch January 4, 2025 17:34
@krauspe
Copy link

krauspe commented Jan 5, 2025

What does this mean for raspberry pi platforms ?
I know that raspberry pi v3 uses armv8 and more recent versions armv9. Does this update supports armv8 and 9 ? You mentioned nothing about that.

@nightshade00013
Copy link

What does this mean for raspberry pi platforms ? I know that raspberry pi v3 uses armv8 and more recent versions armv9. Does this update supports armv8 and 9 ? You mentioned nothing about that.

V8 and V9 will still be supported. Dropping support for older architecture is common as software moves forward that doesn't mean newer versions are unsupported just that older ones can no longer handle what we are trying to do with them. Raspberry pi's that use armV8 or newer will be safe for the time being, same for those using something like the Odroid N2+

@krauspe
Copy link

krauspe commented Jan 5, 2025

Thanks for your info ! I was really concerned, but with a raspi v4 I should hopefully be save so far.

@eswjm1981
Copy link

I have a Pi4, but the update tells me its not supported?

@frenck
Copy link
Member Author

frenck commented Jan 6, 2025

@eswjm1981 See this issue for more information: #2019

@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change A breaking change for existing users. major This PR causes a major version bump in the version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants