Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE RUB: Use SameValidationExceptionAs instead of SameExceptionAs #2654

Closed
wants to merge 1 commit into from

Conversation

kandarpgautam
Copy link

@kandarpgautam kandarpgautam commented Feb 12, 2024

closes #569

In StudentServiceTests.Validations.Modify.cs,

  1. Use SameValidationExceptionAs instead of SameExceptionAs.
  2. Ensure that the test succeeds.

@kandarpgautam kandarpgautam changed the title Use SameValidationExceptionAs instead of SameExceptionAs CODE RUB: Use SameValidationExceptionAs instead of SameExceptionAs Feb 12, 2024
@kandarpgautam
Copy link
Author

kandarpgautam commented Feb 19, 2024

@hassanhabib Can you give me feedback, if this fix is fine or if am I missing something?

@kandarpgautam kandarpgautam changed the title CODE RUB: Use SameValidationExceptionAs instead of SameExceptionAs MinorFix: Use SameValidationExceptionAs instead of SameExceptionAs Mar 1, 2024
@kandarpgautam kandarpgautam changed the title MinorFix: Use SameValidationExceptionAs instead of SameExceptionAs Minor Fix: Use SameValidationExceptionAs instead of SameExceptionAs Mar 1, 2024
@kandarpgautam kandarpgautam changed the title Minor Fix: Use SameValidationExceptionAs instead of SameExceptionAs CODE RUB: Use SameValidationExceptionAs instead of SameExceptionAs Mar 1, 2024
@kandarpgautam
Copy link
Author

Closing this Pull request as it did not follow the naming convention for the branch name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant