Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document GHC-56147 #462

Merged
merged 3 commits into from
Sep 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{-# LANGUAGE Safe #-}
module IgnoredRule where


myId :: a -> a
myId x = x
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{-# LANGUAGE Safe #-}
module IgnoredRule where

{-# RULES "myId" forall x. myId x = x #-}
myId :: a -> a
myId x = x
14 changes: 14 additions & 0 deletions message-index/messages/GHC-56147/ignored-rule/index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
title: Cannot add a rewrite rule for the identity function
---

Wanting to rewrite occurrences of `myId x` to `x` in programs is sensible. But since GHC cannot check in general whether rewrite rules violate the guarantees of SafeHaskell, GHC chooses to ignore all such rules in modules which are annotated as `Safe`.These rewrite rules should therefore be removed.

```
messages/GHC-56147/ignored-rule/before/IgnoredRule.hs:4:11: warning: [GHC-56147]
Rule "myId" ignored
Defining user rules is disabled under Safe Haskell
|
4 | {-# RULES "myId" forall x. myId x = x #-}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
10 changes: 10 additions & 0 deletions message-index/messages/GHC-56147/index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
title: Rewrite rules are ignored in Safe Haskell
summary: Rewrite rules are not allowed in Safe Haskell and are therefore ignored
severity: warning
introduced: 9.6.1
---

GHC implements the `SafeHaskell` extension which allows programmers to restrict modules to a specific subset which is considered safe and does not contain loopholes such as `unsafePerformIO`.
More details are available in [the GHC User's Guide](https://downloads.haskell.org/ghc/latest/docs/users_guide/exts/safe_haskell.html).
One of the features which isn't considered safe are user-specified rewrite rules. GHC therefore warns that all rewrite rules in a module which is declared safe will be ignored.