Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document GHC-97044 #445
Document GHC-97044 #445
Changes from 1 commit
2afa716
250bf8f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least for the
HasField
typeclass it is possible to create user-written instances. See for example my library here: https://github.com/BinderDavid/tuple-fields/blob/main/src/Data/Tuple/Fields.hsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Seems like I was misled by browsing around GHC codebase and I interpreted this
https://github.com/ghc/ghc/blob/2af23f0e84eec0eb30d77134abd99858a02d7a18/compiler/GHC/Tc/Validity.hs#L1460
to mean that HasField can also trigger this warning.
But after deeper look it seems to be related to other "validations" done on instances of this type class.
As for other typeclasses mentioned, I'm pretty sure they should be there as I saw them mentioned in warnings in ghc test suite: https://github.com/search?q=repo%3Aghc%2Fghc%2097044&type=code