Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document GHC-54540 and GHC-93557 #425

Merged
merged 3 commits into from
Jul 9, 2023
Merged

Document GHC-54540 and GHC-93557 #425

merged 3 commits into from
Jul 9, 2023

Conversation

BinderDavid
Copy link
Collaborator

@BinderDavid BinderDavid commented Jun 10, 2023 •
edited
Loading

Fixes #131

@BinderDavid BinderDavid force-pushed the ghc-93557-ghc-54540 branch from 20d37c3 to 14258db Compare June 11, 2023 13:22
@BinderDavid BinderDavid force-pushed the ghc-93557-ghc-54540 branch from 14258db to f1d773f Compare June 11, 2023 13:41
@BinderDavid BinderDavid marked this pull request as ready for review June 11, 2023 13:45
@BinderDavid BinderDavid changed the title WIP: Document GHC-54540 and GHC-93557 Document GHC-54540 and GHC-93557 Jun 11, 2023
david-christiansen
david-christiansen reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@david-christiansen david-christiansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A weird language nitpick, and one real suggestion

message-index/messages/GHC-54540/constructorsNotInScope/after/ConstructorsNotInScope.hs Outdated Show resolved Hide resolved
message-index/messages/GHC-93557/illegalSynonymInstance/index.md Outdated Show resolved Hide resolved
message-index/messages/GHC-93557/illegalSynonymInstance/index.md Outdated Show resolved Hide resolved
message-index/messages/GHC-93557/index.md Outdated Show resolved Hide resolved
message-index/messages/GHC-93557/index.md Outdated Show resolved Hide resolved
message-index/messages/GHC-93557/index.md Show resolved Hide resolved
@BinderDavid
Copy link
Collaborator Author

Thanks for the comments. I applied the suggested changes in one commit.

@BinderDavid
Copy link
Collaborator Author

Ping @david-christiansen . If you don't complain then I will merge this tonight. I think I fixed all your remarks in the way you intended :)

@david-christiansen
Copy link
Contributor

david-christiansen commented Jul 9, 2023 via email

@BinderDavid BinderDavid merged commit 93b0256 into main Jul 9, 2023
@BinderDavid BinderDavid deleted the ghc-93557-ghc-54540 branch September 27, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-christiansen david-christiansen david-christiansen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DerivErrDataConsNotAllInScope -> 54540
2 participants
@BinderDavid @david-christiansen