-
Notifications
You must be signed in to change notification settings - Fork 70
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
eaae755
commit 52dc88a
Showing
4 changed files
with
35 additions
and
0 deletions.
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
message-index/messages/GHC-08838/WrongDoBind/after/WrongDoBind.hs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module WrongDoBind where | ||
|
||
doubleReturn :: forall m. Monad m => m Int | ||
doubleReturn = return 10 |
6 changes: 6 additions & 0 deletions
6
message-index/messages/GHC-08838/WrongDoBind/before/WrongDoBind.hs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
module WrongDoBind where | ||
|
||
doubleReturn :: forall m. Monad m => m Int | ||
doubleReturn = do | ||
return (return 10 :: m Int) | ||
return 10 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
|
||
--- | ||
title: Double return | ||
--- | ||
|
||
In this example, there is a nested return whose result is not bound to a variable. Therefore the computation `return 10` is not used and can be removed. | ||
|
||
``` | ||
messages/GHC-08838/WrongDoBind/before/WrongDoBind.hs:5:4: warning: [GHC-08838] [-Wwrong-do-bind] | ||
A do-notation statement discarded a result of type ‘m Int’ | ||
Suggested fix: | ||
Suppress this warning by saying ‘_ <- return (return 10 :: m Int)’ | ||
| | ||
5 | return (return 10 :: m Int) | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
title: Wrong do bind | ||
summary: Returning a monadic computation in a do block and not binding it will not run it | ||
severity: warning | ||
introduced: 9.4.1 | ||
--- | ||
When using a monadic computation in a do block one should either run it | ||
directly or bind the result of the computation to a variable. If neither | ||
is done the monadic computation is never run and can be removed. |