handle when there is an uncreated chapter #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the file _data/contents.yml had reference to a chapter which does not exist for the default languge, this code would error. Commenting out the three which did not exist fixed the problem. at time of writing, these were: - types - algebraic-data-types - lists-tuples - pattern-matching-control-flow instead fo commenting those out though, I decided to make the code a little more robust to handle this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue that is currently plaguing #28 (and, I suspect, #29 as well)
If the file _data/contents.yml had reference to a chapter which does not
exist for the default languge, this code would error. Commenting out the
three which did not exist fixed the problem.
at time of writing, these were:
instead fo commenting those out though, I decided to make the code a
little more robust to handle this case.