Add defaultGshowsPrec using showsPrec
#20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ping? |
Collaborator
|
Is this holding up having I'll probably make a scan on my libraries when GHC-8.10 is released, so I'm deliberately holding up from merging & releasing stuff. |
phadej
requested changes
Apr 8, 2022
Collaborator
phadej
left a comment
phadej
left a comment
There was a problem hiding this comment.
As mentoned in other PR review. I'm not a fan of default definitions. (define newtype, use DerivingVia).
Also don't stack PRs.
Ericson2314
changed the title
GShow -- contains #18defaultGshowsPrec using showsPrec
Contributor
Author
|
This no longer makes a default method. It also no longer depends on #18. |
`GShow t` is isomorphic to `forall a. Show (t a)`, but we don't need the quantified constraint to write a function to be used to define the method. The more specific type should make a nicer error if one didn't derive the necessary polymorphic `Show` instance.
Contributor
Author
|
@phadej Please review this. |
Collaborator
|
Amdended and merged in #48 and released https://hackage.haskell.org/package/some-1.0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GShow tis isomorphic toforall a. Show (t a), but we don't need thequantified constraint to write a function to be used to define the
method.
The more specific type should make a nicer error if one didn't derive
the necessary polymorphic
Showinstance.