Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert serverExecutablePath from machine to resource scope #394

Merged
merged 3 commits into from
May 12, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented May 11, 2021

@jneira jneira requested a review from lukel97 May 11, 2021 22:07
Copy link
Collaborator

@lukel97 lukel97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit out of the loop but briefly scanned the linked issue: I can understand how this would break workflows but I do think that, security aside, having any sort of setting relating to an absolute file system path should probably be machine local. File paths to executables aren't exactly portable

@jneira jneira merged commit a09c9be into haskell:master May 12, 2021
@nc6
Copy link

nc6 commented May 12, 2021

Machine local isn't the problem so much as machine global. E.g. the point of having the path set per folder/workspace isn't to share between machines, but to have it differently in different folders on the same machine.

If there were a way to allow the latter without the former, that would be fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants