Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with multiple servers after upgrading languageclient to 4.1.3 #65

Closed
Tehnix opened this issue Apr 8, 2018 · 0 comments
Closed

Issues with multiple servers after upgrading languageclient to 4.1.3 #65

Tehnix opened this issue Apr 8, 2018 · 0 comments
Labels
type: bug A bug or unintended effect

Comments

@Tehnix
Copy link
Contributor

Tehnix commented Apr 8, 2018 •
edited
Loading

Currently tracked in microsoft/vscode-languageserver-node#333.

After upgrading vscode-languageclient from 3.5.0 to 4.1.3, we are having problems with multiple spawned language servers, which is needed for multi-root support. I want to note that this works in 3.5.0, and some breaking change was introduced (or errors were made non-silent) in 4.x.

The error comes from hie giving back its capabilities on initialization, where it registers executeCommandProviders. When a second server gets spawned, this command already exists, and VSCode then complains about this.
alanz added a commit to alanz/haskell-ide-engine that referenced this issue May 19, 2018
@alanz
Do not register executeCommandProvider on startup
386e521 
This was a holdover from early experiments, and now breaks vscode.

Fixes haskell/vscode-haskell#65
@alanz alanz mentioned this issue May 19, 2018
Merged
@alanz alanz mentioned this issue May 24, 2018
Closed
alanz added a commit to alanz/haskell-ide-engine that referenced this issue May 24, 2018
@alanz
Register possible commands for excecuteCommand
4dc40ca 
Otherwise vscode will not use them.

Closes haskell/vscode-haskell#85
Reopens haskell/vscode-haskell#65
@alanz alanz mentioned this issue May 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A bug or unintended effect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tehnix