Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PosixString.hsc: expose Fd #311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

domenkozar
Copy link

No description provided.

@hasufell
Copy link
Member

Why?

Neither System.Posix.IO.ByteString, nor System.Posix.IO re-export them.

If we wanted, we should be consistent. I'm not sure how I generally feel about re-exporting base types.

@domenkozar
Copy link
Author

Quite a few of functions have Fd in their type signature, so now I need to import it from System.IO if I want to use them.

The way I see it, it already exposes the API on the Fd so it just makes it convenient to have it as one import.

The same goes for SeekMode.

@hasufell
Copy link
Member

I don't have a strong opinion, but it should be consistent.

@hasufell
Copy link
Member

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants