More Windows subprocess mitigations #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another aspect of the BatBadBut vulnerability that the previous patch did not address is the fact that `%` cannot be easily escaped in a double-quoted string. The vulnerability discussion suggests transliterating `%` as `%%cd:~,%`, which should evaluate to an empty string assuming that the `DelayedExpansion` registry setting is disabled. Here I have implemented this additional mitigation.
sheaf
reviewed
Apr 22, 2024
bgamari
force-pushed
the
wip/windows-2
branch
from
9dca237
to
f6648bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation and implement the escaping logic for
%noted in https://flatt.tech/research/posts/batbadbut-you-cant-securely-execute-commands-on-windows/.