Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax filepath upper bound #298

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Relax filepath upper bound #298

merged 1 commit into from
Dec 16, 2023

Conversation

hasufell
Copy link
Member

No description provided.

@hasufell hasufell mentioned this pull request Dec 15, 2023
Closed
@tomjaguarpaw
Copy link
Member

Thanks! I can't tell from the Github Actions whether the new filepath is being used there. Stack isn't printing out anything about the dependencies. However, I can confirm this builds locally with 1.5.

@tomjaguarpaw tomjaguarpaw merged commit 1d3d39d into haskell:master Dec 16, 2023
18 checks passed
@hasufell
Copy link
Member Author

1.5 only had changes to the OsPath API, which isn't used by process.

@hasufell
Copy link
Member Author

Can we make hackage revisions? I'm not too sure how these even work with boot libraries.

@tomjaguarpaw
Copy link
Member

Yes, revised for 1.6.18.0: https://hackage.haskell.org/package/process-1.6.18.0/revisions/

As I understand it, revisions are fine for boot libraries. It's built-in/"non-upgradable" libraries (base, ghc-prim, ghc-prim etc.) that can't have their dependencies changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjaguarpaw tomjaguarpaw Awaiting requested review from tomjaguarpaw

@bgamari bgamari Awaiting requested review from bgamari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hasufell @tomjaguarpaw