Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP for cabal show-build-info #301

Closed
wants to merge 2 commits into from
Closed

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Jul 9, 2021

Use features from haskell/cabal#7478

Starts work on #269

@jneira
Copy link
Member

jneira commented Oct 18, 2021

I guess it is using (or it can use) the already merged haskell/cabal#7498

@georgefst
Copy link

I'm curious, with upstream support in Cabal seemingly now implemented, is there anything blocking this? There are a lot of issues in HLS which mention this as the solution.

@fendor
Copy link
Collaborator Author

fendor commented Oct 4, 2023

Yeah, there are unfortunately a couple of open issues 😅 Also, #409 essentially implements proper multi-home unit support without show-build-info.

@georgefst
Copy link

But #409 doesn't solve the issue of the user having to manually load all the right components to prevent errors like haskell/haskell-language-server#1370. I thought the point of show-build-info was that it finally gives us the information we need in order to know which components to load.

@georgefst
Copy link

But #409 doesn't solve the issue of the user having to manually load all the right components to prevent errors like haskell/haskell-language-server#1370.

Or maybe it does? I just noticed from haskell/haskell-language-server#3738 that the latest HLS release doesn't incorporate those commits yet.

@fendor
Copy link
Collaborator Author

fendor commented Oct 5, 2023

But #409 doesn't solve the issue of the user having to manually load all the right components to prevent errors like haskell/haskell-language-server#1370. I thought the point of show-build-info was that it finally gives us the information we need in order to know which components to load.

It does! Conceptually, cabal repl --enable-multi-repl computes all the components you need to load into ghci, invokes ghci via ghci @args.unitA.txt @args.unitB.txt and HLS simply looks at these args and sets up the session appropriately.
Currently, the only advantage seems to be that show-build-info uses a well-defined interface instead of the hacky cabal repl -w hie-bios-ghc solution.

@georgefst
Copy link

Aha, awesome! Well then, I very much look forward to HLS being released with the new hie-bios.

@fendor
Copy link
Collaborator Author

fendor commented Nov 6, 2023

I currently don't intend to work on this and it should be superseded by #409

@fendor fendor closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants