-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error overlays #770
Merged
Merged
Error overlays #770
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c72d379
haskell-load: faces for overlay painting
deepfire 8697e23
haskell-load: haskell-check-paint-overlay, steal from ghc-mod
deepfire d6dd2bf
haskell-load | haskell-process-errors-warnings: overlay painting
deepfire 59518ff
haskell-goto-{prev,next}-error: implement
deepfire 68427ca
keybindings | haskell-mode: use M-n / M-p for error/warning overlay …
deepfire ecc358f
overlays: refactor message type handling a little
deepfire e683435
overlays: put a brief overlay summary into the modeline
deepfire f84845a
haskell-process-error-warnings: fix docstring
deepfire e75d6e3
haskell-load: with-overlay-properties
deepfire bfab941
haskell-error-overlay-briefly: employ WITH-OVERLAY-PROPERTIES
deepfire File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these going to conflict with ghc-mod?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielG, do you mean with:
I must say I overlooked this, then..
But then, there's the more pressing question of having two sets of overlays on at the same time, which is still unresolved.