Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New variable to allow user to enable/disable prompts on starting REPL #769

Merged
merged 1 commit into from
Jul 23, 2015

Conversation

vlatkoB
Copy link
Contributor

@vlatkoB vlatkoB commented Jul 21, 2015

  • Added haskell-process-load-or-reload-p variable with default value t meaning "do make prompt", so current flow is not changed unless user changes the variable to nil.
  • Three functions changed just to check for haskell-process-load-or-reload-p variable and, depending on its value, make a prompt or accept the default:
    haskell-session-new-assume-from-cabal

haskell-utils-read-directory-name

haskell-session-target

@gracjan
Copy link
Contributor

gracjan commented Jul 23, 2015

@vlatkoB: Almost great!

This should be defcustom.

Also make the default to NOT PROMPT. You will make a lot people happy that way. Okay?

@vlatkoB
Copy link
Contributor Author

vlatkoB commented Jul 23, 2015

Done.
Travis fails because haskell-sort-imports.el changed in the mean time. Should you fix that, or should I?

@gracjan
Copy link
Contributor

gracjan commented Jul 23, 2015 via email

If haskell-process-load-or-reload-prompt is nil, there will be no
prompts on starting REPL, and all the defaults are accepted.
gracjan added a commit that referenced this pull request Jul 23, 2015
New variable to allow user to enable/disable prompts on starting REPL
@gracjan gracjan merged commit 387e241 into haskell:master Jul 23, 2015
@gracjan
Copy link
Contributor

gracjan commented Jul 23, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants