Add haskell-lexeme.el #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ((member char '(?\] ?\[ ?\( ?\) ?\{ ?\} ?\` ?\, ?\;)) | ||
| 'special)))) | ||
|
|
||
| (defun haskell-utils-match-string-equal (string &optional index) |
There was a problem hiding this comment.
would haskell-utils.el be the better place for this function?
|
@gracjan I keep an eye on every pull request and issue, and this is no exception. This looks good to me, but my level of Haskell experience does not allow me to give any valuable comments on this (besides small notice I've already put). Overall, I think this is very important for present and future development. Good stuff. |
|
Thanks for the feedback.
Is there any other test that you can think of and should be implemented?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Haskell tokenizer, with all bells a whistles, Unicode support, all GHC special cases and stuff.
Related to #724.