Stylish haskell after save

[bergey]

Fixes #1074. Fixes #788. Fixes #256.

[bergey]

Whoops. Force-pushed parenthesis fix.

[gracjan]

Nice triple kill! Thanks.

[wraithm]

I updated to the newest melpa version of haskell-mode today. With haskell-stylish-on-save t in my emacs config, haskell-mode reverts changes that I made on a save. The Messages buffer only says,

Saving file /path/to/my/haskell/File.hs...
Wrote /path/to/my/haskell/File.hs

If I comment out my haskell-stylish-on-save t, everything works again.

[gracjan]

Ha! See here: https://github.com/haskell/haskell-mode/blob/master/haskell-commands.el#L824

         (_errcode (with-temp-file tmp-file
             (call-process cmd filename
                   (list (current-buffer) err-file) nil)))

Although there is a temp file generated, it is not used, the original filename is used and stylish-haskell replaces its contents.

[gracjan]

@bergey: can you fix this? Thanks.

[gracjan]

(note: I've reverted the change for now).

[bergey]

Sorry about that. Thanks for the diagnosis and reverting for now. I'll fix it, probably next weekend.

[gracjan]

Great!

[wraithm]

Thank you both for all of your hard work :)

[gracjan]

@wraithm, actually can you help us with this? You have the commits by @bergey and I've pointed you to the problem of using original file name instead of temporary file name. Can you try to fix this?

Helpful info how to pull a pull request is here: https://help.github.com/articles/checking-out-pull-requests-locally/

Can you give it a try?

[wraithm]

Yeah! I'm down to try. I'm a novice in elisp, but this is a good excuse to learn.

What would you recommend for setting up a development environment? Like, I have the melpa version of haskell-mode installed right now. Is there a good way to tell emacs to load up my fork instead? I've cloned my fork in my home directory (ie. ~/haskell-mode)

[wraithm]

Nevermind. I think I figured it out. I just added my fork to the load-path, and that seemed to do it.

[gracjan]

Yes, load-path is the way to go!

[gracjan]

@wraithm, @bergey: Is this moving forward?

[bergey]

Sorry, I got busy with other projects, and don't foresee getting back to this.

[wraithm]

Yeah, I'm sorry :( I similarly got distracted with work. I'm going to work on this now.

[wraithm]

Okay, so I got it working, but errors from stylish-haskell get dumped into the buffer...

[wraithm]

Making a PR now so you guys can look at it

[wraithm]

#1266

[wraithm]

#1268

Okay!