-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stylish haskell after save #1137
Conversation
5784f70
to
df528b8
Compare
Whoops. Force-pushed parenthesis fix. |
Nice triple kill! Thanks. |
I updated to the newest melpa version of haskell-mode today. With
If I comment out my |
Ha! See here: https://github.com/haskell/haskell-mode/blob/master/haskell-commands.el#L824 (_errcode (with-temp-file tmp-file
(call-process cmd filename
(list (current-buffer) err-file) nil))) Although there is a temp file generated, it is not used, the original filename is used and |
@bergey: can you fix this? Thanks. |
(note: I've reverted the change for now). |
Sorry about that. Thanks for the diagnosis and reverting for now. I'll fix it, probably next weekend. |
Great! |
Thank you both for all of your hard work :) |
@wraithm, actually can you help us with this? You have the commits by @bergey and I've pointed you to the problem of using original file name instead of temporary file name. Can you try to fix this? Helpful info how to pull a pull request is here: https://help.github.com/articles/checking-out-pull-requests-locally/ Can you give it a try? |
Yeah! I'm down to try. I'm a novice in elisp, but this is a good excuse to learn. What would you recommend for setting up a development environment? Like, I have the melpa version of haskell-mode installed right now. Is there a good way to tell emacs to load up my fork instead? I've cloned my fork in my home directory (ie. |
Nevermind. I think I figured it out. I just added my fork to the load-path, and that seemed to do it. |
Yes, |
Sorry, I got busy with other projects, and don't foresee getting back to this. |
Yeah, I'm sorry :( I similarly got distracted with work. I'm going to work on this now. |
Okay, so I got it working, but errors from stylish-haskell get dumped into the buffer... |
Making a PR now so you guys can look at it |
Okay! |
Fixes #1074. Fixes #788. Fixes #256.