Disable ghcide-bench by default #4376
Open
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a cabal flag to control the building of `ghcide-bench`, which is an internal tool for benchmarking HLS. This fixes a regression, where running `cabal install haskell-language-server` would install `ghcide-bench` as well as the required HLS executables.
|
Do we need to update the github CI as well ? |
|
Yeah probably, thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a cabal flag to control the building of
ghcide-bench, which is an internal tool for benchmarking HLS.This fixes a regression, where running
cabal install haskell-language-serverto install HLS from Hackage would installghcide-benchas well as the required HLS executables.Fixes #4359
POC, so we can iterate on this.