New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path newtype declaration #4372

Draft

komikat wants to merge 6 commits into haskell:master from komikat:typed-filepaths

Contributor

komikat commented Aug 1, 2024

Phantom type with one parameter (Abs/Rel)
ghcide refactor in progress


          Path newtype declaration

cd89602

komikat mentioned this pull request

[WIP] parallelising ghcide tests #4364

Draft

4 tasks

komikat added 5 commits

August 2, 2024 13:17


          refactor crade error to use Path

5c592f5


          Shake.hs type checking issues fix

d6aef66


          refactor ghcide to use typed paths

7ff436f


          finish up ghcide typed paths refactor

a5699e7


          absolute path assertions

fd8254d

Contributor Author

komikat commented Aug 17, 2024

simple plugin failing assertion.
mkAbsFromFp being called for cabal.project somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

michaelpj Awaiting requested review from michaelpj michaelpj will be requested when the pull request is marked ready for review michaelpj is a code owner

fendor Awaiting requested review from fendor fendor will be requested when the pull request is marked ready for review fendor is a code owner

wz1000 Awaiting requested review from wz1000 wz1000 will be requested when the pull request is marked ready for review wz1000 is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet