Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup waitForDiagnosticsFrom #4371

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Speedup waitForDiagnosticsFrom #4371

wants to merge 15 commits into from

Conversation

komikat
Copy link
Contributor

@komikat komikat commented Aug 1, 2024 •
edited
Loading

ref #4339

  • fix waitForDiagnosticsFrom which waits recursively
    • hls-stan-plugin
    • hls-rename-plugin
    • hls-pragma-plugin

fendor and others added 15 commits March 22, 2024 16:01
@fendor
WIP: Speed up hls-hlint-plugin-tests
c6d45c4 
Move test data to temporary directory.
Avoid `waitForDiagnosticsWithSource` as it unconditionally waits for
diagnostics.
@komikat
use captureKickdiagnostics for cabal plugin
30ec196
@komikat
Merge remote-tracking branch '/master' into new-changes-hlint-cabal
69a8351
@komikat
Merge branch 'master' into new-changes-hlint-cabal
a26ef9b
@komikat
Merge branch 'master' into new-changes-hlint-cabal
8909af3
@komikat
fix hlint-plugin resolve tests
1446c19
@komikat
Merge branch 'master' into new-changes-hlint-cabal
68844e1
@komikat
haskell-stylish fix
be84fed
@komikat
fix unused imports
266e791
@komikat
fix unused imports, unused defs
2bcbbbb
@komikat
Merge branch 'master' into new-changes-hlint-cabal
0ad3c11
@komikat
resolve conflicts with master with refactor kickSignal
3311461
@komikat
remove redundant imports
674908d
@komikat
remove more redundant imports
85c13dc
@komikat
refactor kicks to use runWithsignal
faec0ab
This was referenced Aug 1, 2024
Closed
Merged
@komikat
Copy link
Contributor Author

komikat commented Aug 1, 2024

Each test in hls-stan-plugin-tests takes around 5s, investigating if this can be refactored.

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 1, 2024

⚠️ The sha of the head commit of this PR conflicts with #4339. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiemundo eddiemundo Awaiting requested review from eddiemundo eddiemundo will be requested when the pull request is marked ready for review eddiemundo is a code owner

@fendor fendor Awaiting requested review from fendor fendor will be requested when the pull request is marked ready for review fendor is a code owner

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 will be requested when the pull request is marked ready for review wz1000 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@komikat @fendor