Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ormolu-plugin: don’t request GhcSession for useCLI #4170

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ormolu-plugin: don’t request GhcSession for useCLI #4170

wants to merge 1 commit into from

Commits on Apr 9, 2024

  1. ormolu-plugin: don’t request GhcSession for useCLI 

    Probably not the best solution.

When ormolu is requested from the command line, it should do its own
detection of cabal features. If it has to set up the GhcSession just
to get some flags, it blocks saving a file (`formatOnSave = true`),
which is a horrible user experience in cases where the session takes a
minute or more to set up.

Instead, now the plugin only depends on ormolu and the file itself.

Fixes haskell#4168
    @Profpatsch
    Profpatsch committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    4ac7ece View commit details
    Browse the repository at this point in the history