Retrie - calculate imports in the command handler #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we don't have to send the imports back and forth on every code action
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
* Automatically pick up new dependencies hie-bios's componentDependencies returns the dependencies of a cradle that might change the cradle. Add those deps to the shake graph so that the GHC session is newly created whenever they change. For that, add a new rule type, GetHscEnvEq, to cache GHC sessions with the key of GHC options and dependencies. And delete the optGhcSession field from IdeOptions. This is for https://github.com/digital-asset/ghcide/issues/50. hie-bios's componentDependencies can return files that don't exist yet: https://github.com/mpickering/hie-bios/blob/master/src/HIE/Bios/Types.hs#L90-L93. This PR handles changes in the existing dependency files, but doesn't handle newly created dependency files. * address comments * revert hie.yaml * address more comments * add test * make direct cradles work; and use direct cradle in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we don't have to send the imports back and forth on every code action
Fixes #407