Log fourmolu and ormolu version that hls using #3744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
reviewed
Aug 5, 2023
There was a problem hiding this comment.
At the moment this will be fairly noisy: it's logged at Info and it's going to be logged every time there's a formatting request. It seems to me like it would be better to do it once when the plugin is set up, if we can? That might require doing a "version probe" of the CLI tool at startup, but that seems okay?
I think this is vary from #3660, I just want to add some tracing to keep which formatter is using, hence we can locate the problem like haskell/vscode-haskell#920 easily. How about downgrading this log to debug level? |
michaelpj
approved these changes
Aug 5, 2023
July541
changed the title
|
Also log ormolu version. |
fendor
requested changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since fourmolu exported its version from fourmolu-0.12, we can utilize this to log version info.
And this pr also adds the missing fourmolu-0.13 dependency...