Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky test on Windows #3008

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

michaelpj
Copy link
Collaborator

@michaelpj michaelpj commented Jul 1, 2022

I don't think anyone is going to fix this soon, let's just disable it so
we can move on.

Fixes #2997.

@michaelpj michaelpj requested a review from July541 July 1, 2022 11:13
@michaelpj michaelpj requested a review from pepeiborra as a code owner July 1, 2022 11:13
Copy link
Collaborator

@July541 July541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be no because it may succeed, we don't test it on Windows.

Otherwise, LGTM!

ghcide/test/exe/Main.hs Outdated Show resolved Hide resolved
I don't think anyone is going to fix this soon, let's just disable it so
we can move on.

Fixes haskell#2997.
@michaelpj michaelpj force-pushed the mpj/disable-flaky-hover-test branch from 8986d66 to 4204a8d Compare July 1, 2022 15:28
@michaelpj michaelpj added the merge me Label to trigger pull request merge label Jul 3, 2022
@mergify mergify bot merged commit ffef347 into haskell:master Jul 4, 2022
hololeap pushed a commit to hololeap/haskell-language-server that referenced this pull request Aug 26, 2022
I don't think anyone is going to fix this soon, let's just disable it so
we can move on.

Fixes haskell#2997.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-exported symbol hover ghcide test is flaky on Windows
2 participants