simplify hlint plugin Cabal descriptor #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To make |
michaelpj
reviewed
Apr 29, 2022
|
Ah, ignore the last comment, I just read the linked issue in hlint. |
pepeiborra
force-pushed
the
hlint-simplify
branch
2 times, most recently
from
fde6323 to
9baf475
Compare
- the ghc-lib flag is unnecessary, we want to use ghc-lib always for maximum compatibility - the hlint34 flag is unnecessary, we can trust cabal to use the right version
pepeiborra
requested review from
jneira,
Anton-Latukha,
Ailrun and
eddiemundo
as code owners
michaelpj
approved these changes
May 1, 2022
sloorush
pushed a commit
to sloorush/haskell-language-server
that referenced
this pull request
May 21, 2022
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2866 I noticed that
hls-hlint-pluginrequires per-ghc-version flags. This preventscabal install haskell-language-serverfrom working across ghc versions.I think we can get rid of these flags:
ghc-libflag is unnecessary, there is no downside to using ghc-lib always for maximum compatibilityhlint34flag is unnecessary, cabal should be able to use the right version