Skip to content

Use maxBound of uinteger not Int. #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 11, 2021
Merged

Use maxBound of uinteger not Int. #2169

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
65ff051
Use maxBound of uinteger not Int.
pranaysashank Sep 7, 2021
629a724
Add a comment explaining the magic number 2147483647.
pranaysashank Sep 7, 2021
f92905c
Replace usages of maxBound with maxBoundUinteger in test and bench.
pranaysashank Sep 7, 2021
2003171
Merge branch 'master' into master
Ailrun Sep 8, 2021
1e56090
Update lsp issue link
jneira Sep 9, 2021
c68ae91
Merge branch 'master' into master
jneira Sep 10, 2021
5e2be4c
Merge branch 'master' into master
jneira Sep 10, 2021
60a92e9
Merge branch 'master' into master
jneira Sep 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ghcide/src/Development/IDE/LSP/Outline.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ moduleOutline ideState DocumentSymbolParams{ _textDocument = TextDocumentIdentif
(defDocumentSymbol l :: DocumentSymbol)
{ _name = pprText m
, _kind = SkFile
, _range = Range (Position 0 0) (Position maxBound 0) -- _ltop is 0 0 0 0
, _range = Range (Position 0 0) (Position 2147483647 0) -- _ltop is 0 0 0 0
}
_ -> Nothing
importSymbols = maybe [] pure $
Expand Down