Introduce strict versions of modifyVar to improve contention #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
force-pushed
the
modifyVar-strict
branch
from
7d3a283 to
700171c
Compare
These strict versions enforce a new pattern: evaluate outside the lock This minimizes the time the lock is held and should help with contention
pepeiborra
force-pushed
the
modifyVar-strict
branch
from
700171c to
7477345
Compare
wz1000
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These strict versions enforce a new pattern: evaluate outside the lock
This is to minimize the time the lock is held and should help with contention
Eventually, it might make sense to upstream these primitives /cc @ndmitchell