Skip to content

Conversation

@pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Feb 7, 2021

Split the benchmark CI in two jobs that can run in parallel, one for each example.
This required adding phony targets to bench each example independently.
Including phony targets for heap profiling, made it optional, configurable, and no longer used in CI

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but heap profling would be watched locally?

@pepeiborra
Copy link
Collaborator Author

pepeiborra commented Feb 8, 2021

LGTM, but heap profling would be watched locally?

Yes, that's the idea. I added documentation on how to run with profiling locally

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Feb 8, 2021
@pepeiborra pepeiborra merged commit 79c5cc7 into master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me Label to trigger pull request merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants