Skip to content

Add non reversable pragma completion #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2021
Merged

Add non reversable pragma completion #1243

merged 2 commits into from
Jan 21, 2021

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented Jan 21, 2021

Current plugin does not list Safe, Trustworthy, etc.
This PR adds those pragmas.

jneira
jneira approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! out of curiosity, do you use safe haskell?

@Ailrun
Copy link
Member Author

Ailrun commented Jan 21, 2021

@jneira Not in general, but occasionally (especially when doing academic things)

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Jan 21, 2021
@mergify mergify bot merged commit 691f2be into haskell:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jneira jneira jneira approved these changes

Assignees

No one assigned

Labels

merge me Label to trigger pull request merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ailrun @jneira