Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Update LSP options for new haskell-lsp-0.18 #1461

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

lukel97
Copy link
Collaborator

@lukel97 lukel97 commented Nov 18, 2019

No description provided.

@lukel97 lukel97 requested review from alanz and cocreature November 18, 2019 13:34
Copy link
Collaborator

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alanz
Copy link
Collaborator

alanz commented Nov 18, 2019

I am confused. The base for the change seems to be wrong, given bb7c702#diff-5a655777ea47d968463741fc0e8bdbfc

@lukel97
Copy link
Collaborator Author

lukel97 commented Nov 18, 2019

@alanz Yeah the diff for this got messed up. And somehow when I went to push changes, it created a new branch in the haskell org, not my fork

@lukel97
Copy link
Collaborator Author

lukel97 commented Nov 18, 2019

@alanz The only difference is that I removed the Core.documentOnTypeFormattingTriggerCharacters, since we don't support documentOnTypeFormatting requests anyway

@lukel97 lukel97 merged commit d78dadb into haskell:master Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants