Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Add support for building with cabal-3.0.0.0 #1379

Merged
merged 2 commits into from
Sep 4, 2019

Conversation

jneira
Copy link
Member

@jneira jneira commented Sep 4, 2019

  • Use symlink-bindir or install-dir depending on cabal version
  • Add support for building in windows, using install-method=copy
  • Use v2- prefix instead new- (available since cabal-2.4.1.0)

Fixes #1250

* Use `symlink-bindir` or `install-dir` depending on cabal version
* Add support for building in windows, using `install-method=copy`
* Use `v2-` prefix instead `new-` (available since `cabal-2.4.1.0`)
@jneira jneira requested a review from samuelpilz September 4, 2019 11:47
@jneira
Copy link
Member Author

jneira commented Sep 4, 2019

Oh, i've disabled tests when building hie, it makes the installation takes longer to finish and afaik it is not needed for install it.

install/src/Cabal.hs Outdated Show resolved Hide resolved
@samuelpilz
Copy link
Contributor

This seems nice! Thanks

@fendor fendor merged commit c845d3c into haskell:master Sep 4, 2019
@jneira jneira deleted the cabal3-build branch September 6, 2019 11:58
@masaeedu
Copy link

Does this fix #1376 as well?

@fendor
Copy link
Collaborator

fendor commented Sep 11, 2019

@masaeedu
Nope, this is just for building the executables

@masaeedu
Copy link

Ah, my bad.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot do cabal 3.0 build for 8.6.5
4 participants