Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Split out completion from HieExtras #1369

Merged
merged 4 commits into from
Aug 25, 2019
Merged

Split out completion from HieExtras #1369

merged 4 commits into from
Aug 25, 2019

Conversation

lukel97
Copy link
Collaborator

@lukel97 lukel97 commented Aug 25, 2019

Closes #1340

@lukel97 lukel97 added the type: refactor Refactor and tidy up internals. label Aug 25, 2019
@lukel97 lukel97 requested review from lorenzo, alanz and wz1000 August 25, 2019 13:22
@alanz
Copy link
Collaborator

alanz commented Aug 25, 2019

If this is just a rearrangement of code I am fine with it.

@lukel97
Copy link
Collaborator Author

lukel97 commented Aug 25, 2019

Argh appveyor failed because of a chocolatey error. I'm going to ignore this one

@lukel97 lukel97 merged commit 5aa35b2 into haskell:master Aug 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lorenzo lorenzo lorenzo approved these changes

@alanz alanz Awaiting requested review from alanz

@wz1000 wz1000 Awaiting requested review from wz1000

Assignees
No one assigned
Labels
type: refactor Refactor and tidy up internals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split out completion logic
3 participants
@lukel97 @alanz @lorenzo