This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Upgrade to haskell-lsp 0.15 #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukel97
approved these changes
Jul 4, 2019
| Diagnostics d1 <> Diagnostics d2 = Diagnostics (d1 <> d2) | ||
|
|
||
| instance Monoid Diagnostics where | ||
| mempty = Diagnostics mempty |
There was a problem hiding this comment.
The default monoid instance for Map is probably not what we want. This should be Map.unionWith Set.union. the default semi group operation is leftbiased union.
There was a problem hiding this comment.
In any case I think ToJSON should be derivable. Although it looks like NormalizedUri has no instance for ToJSON/FromJSON. This should probably be added in haskell-lsp.
fendor
approved these changes
Jul 4, 2019
|
I'll merge now, please let me know if you wanted me to take any extra actions and I'll open another pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.