Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Fix build for Windows 7 #1304

Merged
merged 4 commits into from
Jun 21, 2019
Merged

Fix build for Windows 7 #1304

merged 4 commits into from
Jun 21, 2019

Conversation

jneira
Copy link
Member

@jneira jneira commented Jun 20, 2019

This pr update the resolver for stack-yaml and stack-8.6.5.yaml to get one with the patched version and add unix-time-0.4.7 as exta dependency for the rest of stack config files.

Copy link
Collaborator

@lorenzo lorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alanz
Copy link
Collaborator

alanz commented Jun 20, 2019

In order to minimise rebuilding for people using hie, we try to only bump resolvers once a month.

Can we maybe just add the extra dep for GHC 8.6.5 and the nightly stack, until they get bumped at the end of the month?

@jneira
Copy link
Member Author

jneira commented Jun 20, 2019

@alanz of course! cache is very valuable with so many deps

@alanz
Copy link
Collaborator

alanz commented Jun 20, 2019

Thanks, LGTM. We can merge this when CI passes

@alanz alanz merged commit d657504 into haskell:master Jun 21, 2019
@alanz
Copy link
Collaborator

alanz commented Jun 21, 2019

And it just struck me we should add

unix-time >= 0.4.7

to the cabal file somewhere.

alanz added a commit to alanz/haskell-ide-engine that referenced this pull request Jun 21, 2019
This makes sure PR haskell#1304 is complete, constraining the cabal build as
well, for Windows 7
@jneira
Copy link
Member Author

jneira commented Jun 21, 2019

@alanz maybe it would be not neccesary (other than doing a cabal update) cause:

  • wai-logger has not upper bound on fast-logger
  • fast-logger has not upper bound on unix-time

it doesnt follow pvp but you have the last patched version without hackage revisions in exchange.
I havent tested it though.
Testing in my win 7 a cabal new-build: it is using unix-time-0.4.7

@alanz
Copy link
Collaborator

alanz commented Jun 21, 2019

Fair enough, but I think I will be happier to actively constrain a lower bound on it, as per #1306

@jneira jneira deleted the fix-win7 branch June 24, 2019 11:48
@alanz alanz added this to the 2019-06 milestone Jul 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants