This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Hlint 2.1.22 #1270
Merged
Hlint 2.1.22 #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expecting GHC 8.2.2 version to fail.
There is a problem in the unit tests, getting feedback for a haskell file with a parse error in it. See ndmitchell/hlint#637
Still get segfault
It still fails, now hanging on the call to applyRefactorings.
This uses ghc-lib-parser-0.20190523, which avoids a segfault present in prior versions when used with haskell-ide-engine.
ghc-lib-parser takes a long time to build the first time.
lukel97
reviewed
May 26, 2019
test.sh
Outdated
|
|
||
| # stack --stack-yaml=stack-8.6.4.yaml test haskell-ide-engine:unit-test --test-arguments "--match \"ApplyRefactPlugin\"" | ||
|
|
||
| # stack --stack-yaml=stack.yaml test haskell-ide-engine:func-test --test-arguments "--match \"/FunctionalCodeActions/code actions/hlint suggestions/provides 3.8 code actions/\"" |
There was a problem hiding this comment.
Did you mean to add this file?
There was a problem hiding this comment.
I added it to help the ghc-lib-parser guys track down the problem. I guess it can be removed again.
[skip ci] [ci skip]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring in hlint-2.1.22, which uses
ghc-lib-parserwhen it can, instead ofhaskell-src-exts.It does not support GHC < 8.4, so those still use the older
hlint.