Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

hie sends invalid message on hover #1246

Closed
wants to merge 1 commit into from

Conversation

Hogeyama
Copy link
Contributor

@Hogeyama Hogeyama commented May 7, 2019

When there is no information available against a hover request, hie returns a response like

{"result":{"contents":null},"jsonrpc":"2.0","id":1}

which does not respect the Language Server Protocol in which contents cannot be null:

interface Hover {
    contents: MarkedString | MarkedString[] | MarkupContent;
    range?: Range;
}

This PR includes a temporal measure for this problem.
It would be better to fix haskell-lsp so as not to allow null in HoverContents.
I've opened the issue on haskell-lsp too.

@alanz
Copy link
Collaborator

alanz commented May 7, 2019

See discussion at haskell/lsp#162

alanz added a commit to alanz/haskell-ide-engine that referenced this pull request May 8, 2019
@alanz alanz mentioned this pull request May 8, 2019
@Hogeyama Hogeyama closed this May 9, 2019
@alanz alanz added this to the 2019-05 milestone Jun 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants