Helpful error message on missing mirror group #1054
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR:
Not very helpful, since you can't see what kind of problem there was. Were the credentials wrong? It's hard to tell.
One problem is that the server doesn't know that the client wants the error
message as
text/plain, so this PR adds thisAcceptheader.This PR also improves the generated message such that it includes the groups
against which the users' membership is checked. It is done by added a generic group checker
mechanism, that could potentially be used in more places. But for now, only the
mirror client uses this.
After this PR, the message is much improved: