Restore two-column layout for very wide viewports #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I failed to test for very wide viewports where the
#contentmax-width of 1450px comes into play. In this case, the left-pane would be too wide, and the properties pane would be pushed down, as shown on the first screenshot.Before this PR:
The width of 887px is more than 60% of 1450px minus 2em (which equals 870px minus 2em), which means that there is no room for the properties pane. It would exceed that limit by even more as the screen grows larger (see later for how to reproduce).
This is fixed by using the
min(...)CSS function to provide this upper limit. Now the two columns are used as expected:To reproduce this, you can simply just zoom out using Control-Hyphen. This makes the pixel size smaller, which eventually triggers this problem.