update DataTables #1025
Merged
update DataTables #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Datatables will be subsumed in 90% of cases by the new browse functionality which uses something else. As such I'm fine switching to a cdn for this since its not going to be core functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates DataTables from 1.10.12 to 1.11.4. Is it okay to update this?
I've found it necessary to update DataTables to complete #1008
Specifically, I think the older version of DataTables currently used does not support setting the text color of the "SearchPanes" extension (Show 10 entries ... Filter).
The source is https://datatables.net/download/ ; the styling framework is "DataTables default styling," the package is "DataTables," and one enabled extension is "SearchPanes." No other options are selected.
The PR deletes the current version of DataTables from version control, and uses the DataTables CDN instead. (For jQuery #1026)
I think the result is identical:
