This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Make Filetargets absolute before continue using them #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
make-filetargets-absolute
branch
from
7ce49a9 to
414ee64
Compare
|
Thanks! We didn't see any bug reports about this because the cabal and stack cradles produce module targets, right? |
pepeiborra
approved these changes
Nov 17, 2020
|
For the executables main module you get file targets. I got a bug report on IRC, but the IDE kept working for the module anyways. However, there is a problem (with the mentioned error message) in the vscode problems tab. You can actually provoke it pretty easily, e.g. open main executable of cabal, or in the test project I added here. |
fendor
force-pushed
the
make-filetargets-absolute
branch
from
414ee64 to
d71667f
Compare
fendor
force-pushed
the
make-filetargets-absolute
branch
from
d71667f to
193f461
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filetargets are not correctly absolute. The hie-bios API did not articulate this post-condition correctly.
So, in certain cases, the following error is shown for file-targets in a sub-directory:
Adds a test that this was the case and is now fixed.