This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Parenthesize operators when exporting #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even one of them would be great 😉 |
|
I created them separately one by one, consistent with former tests. |
pepeiborra
approved these changes
Nov 12, 2020
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Parenthesize operators when exporting * Add tests * Only consider if the head is an operator letter
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Parenthesize operators when exporting * Add tests * Only consider if the head is an operator letter
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Parenthesize operators when exporting * Add tests * Only consider if the head is an operator letter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
A tiny fix to export operators properly. If I understand correctly, identifiers can be either totally symbolic or alpha num. And it might be safe to use
type ...in the export list:we could define those operators only when TypeOperators is enabled.
Closes haskell/haskell-language-server#589. Perhaps I should add some tests :)
Screenshot