This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Update implicit-hie #905
Merged
Update implicit-hie #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Avi-D-coder
commented
Nov 12, 2020
Avi-D-coder
commented
Avi-D-coder
force-pushed
the
implicit-hie-update
branch
from
3773d7b to
4e686a9
Compare
Avi-D-coder
force-pushed
the
implicit-hie-update
branch
from
4e686a9 to
cd15237
Compare
jneira
reviewed
Nov 12, 2020
| @@ -90,7 +90,7 @@ library | |||
| ghc-paths, | |||
| cryptohash-sha1 >=0.11.100 && <0.12, | |||
| hie-bios >= 0.7.1 && < 0.8.0, | |||
| implicit-hie-cradle >= 0.2.0.1 && < 0.3, | |||
| implicit-hie-cradle >= 0.2.0.1 && < 0.4, | |||
There was a problem hiding this comment.
Maybe we should remove the upper bound? If we are no gonna change the api frequently, maybe it would be handy
There was a problem hiding this comment.
The API will change if hie-bios's changes, I am more conformable with a upper bound.
jneira
approved these changes
Nov 12, 2020
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.