This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
simplify things unnecessarily running in GhcM #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fully agree with the sentiment but just don't have the energy to review right now |
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* simplify things unnecessarily running in GhcM * untick catchSrcErrors * set useUnicode
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* simplify things unnecessarily running in GhcM * untick catchSrcErrors * set useUnicode
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* simplify things unnecessarily running in GhcM * untick catchSrcErrors * set useUnicode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the times we don't need to mutate the
HscEnv, so we don't need to store it in anIORef. The few times we do, it is better to be explicit, instead of risking implicitly throwing away changes by usingevalGhcEnv.