-
Notifications
You must be signed in to change notification settings - Fork 96
Skip unnecessary packing of cache artifacts #794
Conversation
But won't the cache degrade over time? So we get a cache hit, add some new dependencies, but those will never make it to the cache? |
The cache key includes the stack and cabal descriptors, which carry enough signal to ensure the cache doesn't degrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 min less sounds great
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
c65a1b9
to
baf40d4
Compare
.azure/windows-stack.yml
Outdated
@@ -38,9 +38,11 @@ jobs: | |||
- bash: | | |||
curl -sSkL http://www.stackage.org/stack/windows-x86_64 -o /usr/bin/stack.zip | |||
unzip -o /usr/bin/stack.zip -d /usr/bin/ | |||
mkdir -p "$STACK_ROOT" | |||
mkdir -p "$(cygpath $STACK_ROOT)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pepeiborra was cygpath
needed? afaik mkdir -p "C:\x"
works (at least in my local msys console)
atrey@FNTSY MINGW64 /d/dev
$ mkdir -p "D:\dev\test"
atrey@FNTSY MINGW64 /d/dev
$ ls test/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a Windows environment, only added it for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough but i am afraid that the existing cygpath
was the exception (to be removed) :-/
I can remove them in a follow up if you prefer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could fix the caching for the Windows CI I would be eternally grateful. Otherwise I might have to disable since the network connection to the stackage infrastructure (casa.fpcomplete.com
) has become very unreliable and stack builds fail all the time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
151f029
to
bcd65a9
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Caching is broken and stackage builds fail all the time with timeouts to casa.fpcomplete.com
bcd65a9
to
55b3224
Compare
* Skip unnecessary packing (takes 2m) when we had a successful cache hit * Pack before testing * Reenable benchmark CI * Disable Windows CI Caching is broken and stackage builds fail all the time with timeouts to casa.fpcomplete.com
* Skip unnecessary packing (takes 2m) when we had a successful cache hit * Pack before testing * Reenable benchmark CI * Disable Windows CI Caching is broken and stackage builds fail all the time with timeouts to casa.fpcomplete.com
* Skip unnecessary packing (takes 2m) when we had a successful cache hit * Pack before testing * Reenable benchmark CI * Disable Windows CI Caching is broken and stackage builds fail all the time with timeouts to casa.fpcomplete.com
Not needed when we had a successful cache hit, saves ~ 2 minutes