Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Skip unnecessary packing of cache artifacts #794

Merged
merged 4 commits into from
Sep 14, 2020
Merged

Conversation

pepeiborra
Copy link
Collaborator

Not needed when we had a successful cache hit, saves ~ 2 minutes

@ndmitchell
Copy link
Collaborator

But won't the cache degrade over time? So we get a cache hit, add some new dependencies, but those will never make it to the cache?

@pepeiborra
Copy link
Collaborator Author

The cache key includes the stack and cabal descriptors, which carry enough signal to ensure the cache doesn't degrade.

Copy link
Collaborator

@ndmitchell ndmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 min less sounds great

@pepeiborra pepeiborra requested a review from jneira September 13, 2020 10:45
@pepeiborra
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pepeiborra pepeiborra force-pushed the skip-packing branch 2 times, most recently from c65a1b9 to baf40d4 Compare September 13, 2020 19:50
@@ -38,9 +38,11 @@ jobs:
- bash: |
curl -sSkL http://www.stackage.org/stack/windows-x86_64 -o /usr/bin/stack.zip
unzip -o /usr/bin/stack.zip -d /usr/bin/
mkdir -p "$STACK_ROOT"
mkdir -p "$(cygpath $STACK_ROOT)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pepeiborra was cygpath needed? afaik mkdir -p "C:\x" works (at least in my local msys console)

atrey@FNTSY MINGW64 /d/dev
$ mkdir -p "D:\dev\test"

atrey@FNTSY MINGW64 /d/dev
$ ls test/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a Windows environment, only added it for consistency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough but i am afraid that the existing cygpath was the exception (to be removed) :-/
I can remove them in a follow up if you prefer

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could fix the caching for the Windows CI I would be eternally grateful. Otherwise I might have to disable since the network connection to the stackage infrastructure (casa.fpcomplete.com) has become very unreliable and stack builds fail all the time

.azure/windows-stack.yml Outdated Show resolved Hide resolved
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pepeiborra
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Caching is broken and stackage builds fail all the time with timeouts to
casa.fpcomplete.com
@pepeiborra pepeiborra merged commit 7d9d2a5 into master Sep 14, 2020
@pepeiborra pepeiborra deleted the skip-packing branch September 14, 2020 18:39
pepeiborra added a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Skip unnecessary packing (takes 2m) when we had a successful cache hit

* Pack before testing

* Reenable benchmark CI

* Disable Windows CI

Caching is broken and stackage builds fail all the time with timeouts to
casa.fpcomplete.com
pepeiborra added a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Skip unnecessary packing (takes 2m) when we had a successful cache hit

* Pack before testing

* Reenable benchmark CI

* Disable Windows CI

Caching is broken and stackage builds fail all the time with timeouts to
casa.fpcomplete.com
pepeiborra added a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Skip unnecessary packing (takes 2m) when we had a successful cache hit

* Pack before testing

* Reenable benchmark CI

* Disable Windows CI

Caching is broken and stackage builds fail all the time with timeouts to
casa.fpcomplete.com
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants