This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Refinement holes #748
Merged
Refinement holes #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
force-pushed
the
typed-holes
branch
6 times, most recently
from
e8cd500 to
7790be9
Compare
wz1000
approved these changes
Sep 2, 2020
pepeiborra
force-pushed
the
typed-holes
branch
from
7790be9 to
7d7a778
Compare
lukel97
approved these changes
Sep 2, 2020
pepeiborra
force-pushed
the
typed-holes
branch
from
7d7a778 to
835b5cf
Compare
|
This change needs a bit more work, as I found some more complex examples of refinement hole fits are not handled by the new regex approach |
pepeiborra
force-pushed
the
typed-holes
branch
2 times, most recently
from
b415635 to
38f3afb
Compare
pepeiborra
force-pushed
the
typed-holes
branch
2 times, most recently
from
2ffa9cf to
53a5d9a
Compare
|
My second pass is ready for re-review:
|
Refinement hole fits are very cool, but currently too slow to enable at deeper levels. It should eventually be user configurable.
pepeiborra
force-pushed
the
typed-holes
branch
from
eb065a0 to
0a3f501
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
pepeiborra
force-pushed
the
typed-holes
branch
2 times, most recently
from
bff6195 to
4edf523
Compare
pepeiborra
force-pushed
the
typed-holes
branch
from
85e4a0a to
03f02df
Compare
|
Is this OK to merge? |
|
Yes, good to merge if changes requested after re-review |
wz1000
reviewed
Sep 5, 2020
| @@ -94,6 +94,9 @@ data IdeOptions = IdeOptions | |||
| -- Otherwise, return the result of parsing without Opt_Haddock, so | |||
| -- that the parsed module contains the result of Opt_KeepRawTokenStream, | |||
| -- which might be necessary for hlint. | |||
| , optCustomDynFlags :: DynFlags -> DynFlags | |||
There was a problem hiding this comment.
Is this for hls and other downstream users of ghcide?
Tritlo
reviewed
Sep 5, 2020
| $ flip gopt_unset Opt_ShowTypeAppOfHoleFits -- not used | ||
| $ flip gopt_unset Opt_ShowTypeAppVarsOfHoleFits -- not used | ||
| $ flip gopt_unset Opt_ShowTypeOfHoleFits -- massively simplifies parsing | ||
| $ flip gopt_set Opt_SortBySubsumHoleFits -- very nice and fast enough in most cases |
There was a problem hiding this comment.
This line slows the whole thing by a lot, since it does pairwise comparison between every single possible fit, and everything grinds to a halt. I'd strongly recommend you turn it off!
There was a problem hiding this comment.
You mean sort by subsumption right? It wasn't too bad in my empirical tests. It's quadratic complexity but the number of items is small, so only in degenerate cases like _ :: a does it grind to a halt, and ghcide will cancel it as soon as an edit is made anyway.
Overall, there is no set of flags that will make everyone happy, so we should eventually expose this flags as a user configurable setting.
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Refinement holes * Set more GHC options and use indentation for parsing * Add an option to customize the typed holes settings Refinement hole fits are very cool, but currently too slow to enable at deeper levels. It should eventually be user configurable. * GHC Compatibility * Compat. with 8.4
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Refinement holes * Set more GHC options and use indentation for parsing * Add an option to customize the typed holes settings Refinement hole fits are very cool, but currently too slow to enable at deeper levels. It should eventually be user configurable. * GHC Compatibility * Compat. with 8.4
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Refinement holes * Set more GHC options and use indentation for parsing * Add an option to customize the typed holes settings Refinement hole fits are very cool, but currently too slow to enable at deeper levels. It should eventually be user configurable. * GHC Compatibility * Compat. with 8.4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #639